BUG: maybe_promote with dt64tz and mismatched NA #39743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Feb 11, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
user facing? |
trying to track this down; many of the cases that would be affected go through DTA/TDA/PA methods instead of maybe_promote |
so far it looks like the answer is "no", but that the reason involves incorrect NAs being ignored somewhere else that i need to track down separately |
increasingly looking like "no" |
|
OK im now almost positive there is nothing user-facing bc 1) the only currently-incorrect case is in the dt64tz path and 2) that path is AFAICT not reachable by any of the non-test uses of maybe_promote |
|
ok can you rebase |
4 tasks
|
rebased + green (no longer a bugfix, just a refactor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.