Regression in to_excel when setting duplicate column names #39800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Feb 13, 2021
phofl
commented
- closes BUG: DataFrame.to_excel() now raises if column parameter contains duplicates #39695
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
phofl
added
IO Excel
|
Changes LGTM. Restarted CI on failed build since it looks unrelated. |
doc/source/whatsnew/v1.2.2.rst
Outdated
| @@ -27,6 +27,7 @@ Fixed regressions | |||
| - Fixed regression in :meth:`~DataFrame.groupby` or :meth:`~DataFrame.resample` when aggregating an all-NaN or numeric object dtype column (:issue:`39329`) | |||
| - Fixed regression in :meth:`.Rolling.count` where the ``min_periods`` argument would be set to ``0`` after the operation (:issue:`39554`) | |||
| - Fixed regression in :func:`read_excel` that incorrectly raised when the argument ``io`` was a non-path and non-buffer and the ``engine`` argument was specified (:issue:`39528`) | |||
| - Fixed regression in :func:`pandas.to_excel` raising ``KeyError`` when giving duplicate columns with ``columns`` attribute (:issue:`39695`). | |||
There was a problem hiding this comment.
move to 1.2.3 and remove trailing period
There was a problem hiding this comment.
Sorry, somehow I am still at 1.2.2 :(
|
thanks @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 15, 2021
…licate column names
simonjayhawkins
pushed a commit
that referenced
this pull request
Feb 16, 2021
…umn names (#39827) Co-authored-by: patrick <61934744+phofl@users.noreply.github.com>
znicholls
pushed a commit
to znicholls/pandas
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.