CLN: ensure_platform_int earlier #40528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hmm 32-bit is failing here (one of the posix failed too, but that is unrelated i think) |
jbrockmendel
force-pushed
the
cln-intp-libs-3
branch
from
6405ccf to
24527a4
Compare
pandas/core/arrays/categorical.py
Outdated
| categories = self.categories | ||
| r, counts = libalgos.groupsort_indexer( | ||
| self.codes.astype("int64", copy=False), categories.size | ||
| libalgos.ensure_platform_int(self.codes), categories.size |
Member
There was a problem hiding this comment.
IIUC ensure_platform_int should be imported from pandas.core.dtypes.common from the Python code see #40567
Member
Author
There was a problem hiding this comment.
sure, mind if i do this in the next pass? have a branch on deck
Contributor
There was a problem hiding this comment.
ok to do later, but maybe should rebase this PR anyhow as @simonjayhawkins change was merged
Member
Author
|
Ping |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.