Skip to content

TYP: make EA registry private #40538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2021
Merged

TYP: make EA registry private #40538

merged 2 commits into from
Mar 21, 2021

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Mar 20, 2021

From #39501 splitting out the part to make the EA registry private. This will make it so that pyright --verifytypes accepts pandas public API.

@Dr-Irv Dr-Irv requested a review from simonjayhawkins March 20, 2021 16:11
@Dr-Irv Dr-Irv mentioned this pull request Mar 20, 2021
Closed
@Dr-Irv Dr-Irv changed the title make EA registry private TYP: make EA registry private Mar 21, 2021
@Dr-Irv Dr-Irv mentioned this pull request Mar 21, 2021
Merged
4 tasks
@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Typing type annotations, mypy/pyright type checking labels Mar 21, 2021
@jreback jreback added this to the 1.3 milestone Mar 21, 2021
@jreback jreback merged commit d29af92 into pandas-dev:master Mar 21, 2021
@jreback
Copy link
Contributor

jreback commented Mar 21, 2021

thanks @Dr-Irv

@Dr-Irv Dr-Irv deleted the registry branch March 22, 2021 11:58
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@Dr-Irv @JulianWgs
make EA registry private (pandas-dev#40538)
0ecced6
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Irv @jreback