-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: increase codecov target - append ArrayManager tests coverage #40711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: increase codecov target - append ArrayManager tests coverage #40711
Conversation
ci/run_tests.sh
Outdated
@@ -30,6 +30,11 @@ fi | |||
echo $PYTEST_CMD | |||
sh -c "$PYTEST_CMD" | |||
|
|||
if [ "$COVERAGE" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this one is different.
Now, maybe it can't hurt to add the --cov-append
in all cases, though (so also for the first invocation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but let's try to have a single invocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to have a single invocation
There are two invocations, that's the point of also testing the ArrayManager
Attempt to close #40670