-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPS/CLN: remove distutils usage #41207
Conversation
fangchenli
commented
Apr 28, 2021
•
edited
Loading
edited
- close DEPS: remove distutils #41199
hmm didn't realize cc @pandas-dev/pandas-core any comments. |
As mentioned on the issue, we can also vendor the part of the code of |
Why not wait? Python 3.12 is a long way off, and there maybe an official equivalent of LooseVersion in the standard library by then. |
deprecation warnings! i don't think vendoring would be very hard (and this is in general a nice cleaning anyhow) |
Could just import it once in a compat module and catch the deprecation warning. |
I don't think waiting (and add warning catching as workaround for now) would help much. We will have to otherwise do it in 2 years anyway, and they don't plan to add an alternative to the stdlib. For reference, this is the PR that vendored it in pyarrow: https://github.com/apache/arrow/pull/9849/files#diff-01d967ca0c7171567d28b14f96289b349089dcab833c61a83d88f3fb72303591 |
yeah +1 on vendoring. |
If they really aren't going to provide a simple mechanism to handle versioning OOB, then vendoring is the next best. Still total PITA. |
for sure! but this is slightly better than existing |
looks good. can you rebase after #41327 is merged and ping on green. |
@fangchenli #41327 now merged |
thanks @fangchenli very nice! |