Skip to content

DOC: Remove deprecated use of level for agg functions #41394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

ref #40869, cc @phofl

@rhshadrach rhshadrach added Docs Groupby Deprecate Functionality to remove in pandas labels May 9, 2021
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we remove the examples from the userguide too?

@rhshadrach
Copy link
Member Author

rhshadrach commented May 9, 2021

I assumed these would give warnings when building the docs, and there weren't any. Just did some searching through the userguide and didn't find any. However, there are documented cases of Series.sub and Series.div using level. I think these are not deprecated (but maybe should be as well?)

@phofl
Copy link
Member

phofl commented May 9, 2021

Sorry I forgot this. I changed them to using groupby when deprecating the keyword

Edit: Yes they are not deprecated

@jreback
Copy link
Contributor

jreback commented May 10, 2021

I assumed these would give warnings when building the docs, and there weren't any. Just did some searching through the userguide and didn't find any. However, there are documented cases of Series.sub and Series.div using level. I think these are not deprecated (but maybe should be as well?)

.sub and so on are not deprecated; I think we need the level keyword (as it provides broadcasting behavior)

@jreback jreback added this to the 1.3 milestone May 10, 2021
@jreback jreback merged commit e23a1d3 into pandas-dev:master May 10, 2021
@jreback
Copy link
Contributor

jreback commented May 10, 2021

thanks @rhshadrach

@rhshadrach rhshadrach deleted the remove_level_docs branch May 11, 2021 02:00
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Docs Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants