REF: collect methods in NumericIndex #41472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
ref_numeric_index
branch
from
100383d
to
427e208
Compare
topper-123
force-pushed
the
ref_numeric_index
branch
from
427e208
to
7c7db4a
Compare
topper-123
commented
May 14, 2021
jreback
requested changes
May 17, 2021
pandas/core/indexes/numeric.py
Outdated
| else: | ||
| return False | ||
|
|
||
| @property |
pandas/core/indexes/numeric.py
Outdated
| np.float64: libindex.Float64Engine, | ||
| }[self.dtype.type] | ||
|
|
||
| @property |
pandas/core/indexes/numeric.py
Outdated
| @@ -255,6 +357,14 @@ def asi8(self) -> np.ndarray: | |||
| return self._values.view(self._default_dtype) | |||
|
|
|||
|
|
|||
| _int64_descr_args = { | |||
There was a problem hiding this comment.
can you put these in the class?
jreback
added
Index
|
Updated. |
jreback
approved these changes
May 17, 2021
pandas/core/indexes/numeric.py
Outdated
| @@ -150,13 +296,16 @@ def _is_comparable_dtype(self, dtype: DtypeObj) -> bool: | |||
| return is_numeric_dtype(dtype) | |||
|
|
|||
| @classmethod | |||
| def _assert_safe_casting(cls, data, subarr): | |||
| def _assert_safe_casting(cls, data, subarr) -> None: | |||
There was a problem hiding this comment.
Yes, and data too, I can add those.
|
LGTM; if you find anywhere where |
|
Updated type hints. |
|
thanks @topper-123 |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
May 20, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jun 3, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jun 4, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jun 9, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jun 21, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jul 14, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jul 24, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jul 25, 2021
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperates the refactoring of existing methods out of #41153. Will make it easier to see what #41153 actually brings in of new things.
This PR changes no functionality, but only makes the exisiting numeric indexes into thin subclasses of the existing
NumericIndex.