-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add tests for old issues 2 #41493
Conversation
This does not yet close #14564, #14564 (comment)? should maybe change that one to an xref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would split #14564 patches to a separate PR (as per comment) and question above.
@pytest.mark.parametrize( | ||
"dtype, expected_data, expected_index, axis, expected_dtype", | ||
[ | ||
["datetime64[ns]", [], [], 1, "float64"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this expected float64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; I think this should be datetime64[ns]
. Opened up #41544 related to this bug.
).stack() | ||
result = df.to_json() | ||
expected = ( | ||
"{\"(Timestamp('2017-01-20 00:00:00'), 'foo')\":true," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woa, this is the expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so; yes.
The result is similar to #15273 (comment) except I think it's correct that we retain the timestamp like object instead of converting to epoch timestamp
Sorry my comment was a little unclear. Our aggregation ops now support returning
|
thanks @mroeschke |
columns
argument if nested list is passed in as thedata
parameter. #14467