- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 19.2k
 
REF: simplify sanitize_array #41592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            REF: simplify sanitize_array #41592
      
        
          +17
        
        
          −24
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           does this give any perf improvement?  | 
    
| 
           thanks, pls post perf if you can.  | 
    
| 
           will run asvs; will try to see if we have ones that go down all the affected paths  | 
    
| 
           with   | 
    
    
  TLouf 
      pushed a commit
        to TLouf/pandas
      that referenced
      this pull request
    
      Jun 1, 2021 
    
    
  
    
  JulianWgs 
      pushed a commit
        to JulianWgs/pandas
      that referenced
      this pull request
    
      Jul 3, 2021 
    
    
  
      
        
      
      
  
    3 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
We end up calling _try_cast in 3 places instead of 5