DOC: fix docs after deprecation of args #42342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
changed the title
| @@ -5072,9 +5072,9 @@ def between(self, left, right, inclusive="both") -> Series: | |||
| 4 False | |||
| dtype: bool | |||
|
|
|||
| With `inclusive` set to ``False`` boundary values are excluded: | |||
| With `inclusive` set to ``"neither"`` boundary values are excluded: | |||
There was a problem hiding this comment.
hmm, remind me. why did we deprecate True/False as allowable arguments?
There was a problem hiding this comment.
because T/F is only 2 options. 'both', 'neither' 'left' 'right' is all cases. If working towards standardising this type of arg across methods, makes sense to have all encompassing options (#40245)
|
thanks @attack68 |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 3, 2021
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jul 4, 2021
Co-authored-by: attack68 <24256554+attack68@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows up an oversigh from #40628.
Falsewas deprecated as an input so the example should be updated.