Skip to content

BUG: JoinUnit._is_valid_na_for #43043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

jbrockmendel
Copy link
Member

Fixing this unblocks a refactor to share some code with the ArrayManager logic which I think will fix some of the broken ArrayManager cases.

@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel does this need a release note?

@simonjayhawkins simonjayhawkins added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Aug 16, 2021
@jbrockmendel
Copy link
Member Author

No, shouldn’t be user facing

@jreback jreback added this to the 1.4 milestone Aug 16, 2021
@jreback jreback merged commit 78628e9 into pandas-dev:master Aug 16, 2021
@jbrockmendel jbrockmendel deleted the bug-is_valid_na_for branch August 16, 2021 21:47
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants