BUG: Pass index data correctly in groupby.transform/agg w/ engine=numba #43172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Aug 22, 2021
mroeschke
commented
- closes DataFrameGroupBy.aggregate engine='numba' doesn't pass index #43133
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
@mroeschke would be ok with backing this to 1.3.x if ok with that (move release note). |
|
Sure moved to 1.3.3 |
jreback
reviewed
Aug 27, 2021
| @@ -173,3 +173,17 @@ def sum_last(values, index, n): | |||
| result = grouped_x.agg(sum_last, 2, engine="numba") | |||
| expected = Series([2.0] * 2, name="x", index=Index([0, 1], name="id")) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| @td.skip_if_no("numba", "0.46.0") | |||
There was a problem hiding this comment.
total aside we should move the min supported numba version to 0.46.0
|
thanks @mroeschke |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 27, 2021
…by.transform/agg w/ engine=numba
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 27, 2021
…rm/agg w/ engine=numba (#43250) Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.