REF get-axis-number #43263

ForthenchoPacino · 2021-08-27T20:46:08Z

closes Backport PR #43150 on branch 1.3.x (BUG: GroupBy.quantile fails with pd.NA) #43408
whatsnew entry
tests added / passed
Ensure all linting tests pass, see here for how to run them

pep8speaks · 2021-08-27T20:46:14Z

Hello @ForthenchoPacino! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pandas/core/reshape/pivot.py:

Line 317:1: W293 blank line contains whitespace

In the file pandas/io/formats/style.py:

Line 1152:46: E225 missing whitespace around operator
Line 1154:46: E225 missing whitespace around operator

In the file pandas/tests/apply/test_frame_apply.py:

Line 998:57: E225 missing whitespace around operator
Line 1014:46: E225 missing whitespace around operator
Line 1025:46: E225 missing whitespace around operator
Line 1105:57: E225 missing whitespace around operator
Line 1118:64: E225 missing whitespace around operator
Line 1144:64: E225 missing whitespace around operator
Line 1169:64: E225 missing whitespace around operator

In the file pandas/tests/apply/test_frame_transform.py:

Line 50:57: E225 missing whitespace around operator
Line 53:42: E225 missing whitespace around operator

In the file pandas/tests/frame/methods/test_at_time.py:

Line 105:46: E225 missing whitespace around operator
Line 107:46: E225 missing whitespace around operator

In the file pandas/tests/frame/methods/test_between_time.py:

Line 167:46: E225 missing whitespace around operator
Line 172:46: E225 missing whitespace around operator
Line 186:46: E225 missing whitespace around operator
Line 193:46: E225 missing whitespace around operator

In the file pandas/tests/frame/methods/test_set_axis.py:

Line 37:46: E225 missing whitespace around operator

In the file pandas/tests/groupby/test_grouping.py:

Line 550:46: E225 missing whitespace around operator

In the file pandas/tests/window/test_rolling.py:

Line 491:42: E225 missing whitespace around operator

Comment last updated at 2021-08-28 04:40:43 UTC

jbrockmendel · 2021-08-28T00:36:58Z

pandas/core/generic.py

@@ -23,6 +23,7 @@
 )
 import warnings
 import weakref
+from pandas import DataFrame


jbrockmendel · 2021-08-28T00:37:07Z

pandas/io/formats/style.py

-        elif axis in [1, "columns"]:
+        if DataFrame()._get_axis_number(axis)==0:
+         result = data.apply(func, axis=0, **kwargs)
+        if DataFrame()._get_axis_number(axis)==1:


don't make changes to style.py this already has PRs fixing this. please revert.

aight. on it
just to confirm, though, were my changes correct? or were they unnecessary?

jbrockmendel · 2021-08-28T00:37:41Z

What is the motivation for any of this?

ForthenchoPacino · 2021-08-28T04:10:33Z

Why, as in? Like, is it a really inefficient method, or was the whole thing not needed?

attack68 · 2021-08-28T06:39:23Z

pandas/tests/window/test_rolling.py

@@ -488,7 +488,7 @@ def test_rolling_axis_count(axis_frame):

    axis = df._get_axis_number(axis_frame)

-    if axis in [0, "index"]:
+    if DataFrame()._get_axis_number(axis)==0:


axis has already been reduced to an integer in line 489. Sufficient for if axis == 0

Ah. So, has this specific edit been rendered unnecessary?

attack68 · 2021-08-28T06:47:00Z

pandas/tests/apply/test_frame_apply.py

@@ -995,7 +995,7 @@ def test_consistency_for_boxed(box, int_frame_const_col):


 def test_agg_transform(axis, float_frame):
-    other_axis = 1 if axis in {0, "index"} else 0
+    other_axis = 1 if DataFrame()._get_axis_number(axis)==0 else 0


the issue has been revised to avoid fixing test files. Too many new contributors were making mistakes by changing the nature of what was being tested.

So, no touching test files, then?

dont edit test files.

Aight. Won't. Thanks for telling. I'll revert the changes

attack68 · 2021-08-28T06:48:28Z

pandas/tests/groupby/test_grouping.py

@@ -547,7 +547,7 @@ def test_groupby_level_index_names(self, axis):
        df = DataFrame({"exp": ["A"] * 3 + ["B"] * 3, "var1": range(6)}).set_index(
            "exp"
        )
-        if axis in (1, "columns"):
+        if DataFrame()._get_axis_number(axis)==0:


you can do this here, but use existing objects such as df._get_axis_number(axis) == 1. Also note you have got the 0 and 1 wrong here.

Ah. Thanks for point that out, I'll correct it and re-commit

simonjayhawkins · 2021-08-30T11:43:14Z

Thanks @ForthenchoPacino for the PR. I think #43121 fixed the issue for pandas/io/formats/style.py and the other changes are to files in pandas/tests, see #43048 (comment). so closing.

my fixes to the code

9adc255

jbrockmendel reviewed Aug 28, 2021

View reviewed changes

pandas/core/generic.py Outdated

@@ -23,6 +23,7 @@

)

import warnings

import weakref

from pandas import DataFrame

Copy link

Member

jbrockmendel Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

jbrockmendel reviewed Aug 28, 2021

View reviewed changes

checked the extra dataframe imports. hopefully, its fixed now

d00d221

attack68 reviewed Aug 28, 2021

View reviewed changes

MarcoGorelli changed the title ~~my fixes to the code~~ REF get-axis-number Aug 30, 2021

simonjayhawkins closed this Aug 30, 2021

Uh oh!

REF get-axis-number #43263

REF get-axis-number #43263

Uh oh!

Conversation

ForthenchoPacino commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2021-08-28 04:40:43 UTC

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ForthenchoPacino Aug 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbrockmendel commented Aug 28, 2021

Uh oh!

ForthenchoPacino commented Aug 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simonjayhawkins commented Aug 30, 2021

Uh oh!

Uh oh!

ForthenchoPacino commented Aug 27, 2021 •

edited

Loading

pep8speaks commented Aug 27, 2021 •

edited

Loading

ForthenchoPacino Aug 30, 2021 •

edited

Loading

ForthenchoPacino commented Aug 28, 2021 •

edited

Loading