Skip to content

TST: makeMultiIndex not respecting k parameter #43275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

TST: makeMultiIndex not respecting k parameter #43275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5458a9f
changed makeMultiIndex
ShreyasPatel031 Aug 28, 2021
56f6404
Merge branch 'master' of https://github.com/ShreyasPatel031/pandas in…
ShreyasPatel031 Aug 28, 2021
c9b9289
makeMultiIndex fixed
ShreyasPatel031 Aug 28, 2021
136a124
fixed line eroor
ShreyasPatel031 Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/_testing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,10 @@ def makePeriodIndex(k: int = 10, name=None, **kwargs) -> PeriodIndex:


def makeMultiIndex(k=10, names=None, **kwargs):
return MultiIndex.from_product((("foo", "bar"), (1, 2)), names=names, **kwargs)
return MultiIndex.from_product(
(rands_array(nchars=10, size=k),
randu_array(nchars=10, size=k)),
names=names, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this efficiently to avoid future issues?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a test in tests.util



_names = [
Expand Down