Skip to content

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Aug 29, 2021

This pandas option is added to allow the Styler options to be independent from the others. See #41395

  • add option in config
  • add tests
  • whats new
  • options.rst

will update styler user guide as a follow on when all options PRs merged.

Screen Shot 2021-08-29 at 10 01 55

@simonjayhawkins simonjayhawkins added Enhancement IO HTML read_html, to_html, Styler.apply, Styler.applymap Styler conditional formatting using DataFrame.style labels Aug 29, 2021
# Conflicts:
#	doc/source/user_guide/options.rst
#	doc/source/whatsnew/v1.4.0.rst
#	pandas/core/config_init.py
table_attr = self.table_attributes
use_mathjax = get_option("display.html.use_mathjax")
if not use_mathjax:
if not get_option("styler.html.mathjax"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is technically a change in the option name? (its ok to merge this, just mention in the whatsnew)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I will edit the whats new before 1.4.0 release.

@jreback jreback added this to the 1.4 milestone Sep 1, 2021
@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

can you rebase

# Conflicts:
#	doc/source/whatsnew/v1.4.0.rst
#	pandas/core/config_init.py
@jreback jreback merged commit 0070f74 into pandas-dev:master Sep 1, 2021
@attack68 attack68 deleted the styler_mathjax branch September 1, 2021 17:57
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement IO HTML read_html, to_html, Styler.apply, Styler.applymap Styler conditional formatting using DataFrame.style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants