TYP: improve typing for DataFrame.to_string #44426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
phofl
reviewed
Nov 13, 2021
pandas/core/frame.py
Outdated
| self, | ||
| buf: None = None, | ||
| columns: Sequence[str] | None = None, | ||
| col_space: int | None = None, |
There was a problem hiding this comment.
Not directly related to your pr, but this type hint is wrong, can also be list[int] or dict
There was a problem hiding this comment.
Ok, I can look into that. Would like to get current version to pass first, then I’ll do this.
|
cc @simonjayhawkins @twoertwein if comments |
pandas/core/frame.py
Outdated
| @overload | ||
| def to_string( | ||
| self, | ||
| buf: None = None, |
There was a problem hiding this comment.
can leave out the defaults for the overloads. It's only the parameter types that are relevant in overloads.
Suggested change
| buf: None = None, | |
| buf: None = ..., |
simonjayhawkins
requested changes
Nov 15, 2021
There was a problem hiding this comment.
@topper-123 there was a parameter moved in #44331
need changes here to the overloads to prevent mypy errors on merge master.
pandas/core/frame.py:1094: error: Overloaded function implementation does not accept all possible arguments of signature 1 [misc]
pandas/core/frame.py:1094: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
4aa2b8c to
0debdb6
Compare
|
Updated. |
simonjayhawkins
approved these changes
Nov 16, 2021
|
Ping… |
|
Thanks @topper-123 |
|
This is going to fail ci checks... looking now. |
|
FilePathOrBuffer was changed in #43951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.