REF: simplify Block.where (and subtle alignment bug) #44691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anything user facing? (since no new tests guessing no) |
|
Not user facing.
…On Tue, Nov 30, 2021 at 5:04 PM Jeff Reback ***@***.***> wrote:
anything user facing? (since no new tests guessing no)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44691 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6BFBTGMI2HSVKOBZ3DUOVYBTANCNFSM5JCUQW5A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment is not user-facing AFAICT, but comes up when trying to address #44597.