Skip to content

TST: Use IPython instance fixture to avoid file leak #44700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

TST: Use IPython instance fixture to avoid file leak #44700

merged 1 commit into from
Dec 1, 2021

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 1, 2021 •
edited
Loading

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

xref #44634, #35836

Probably should see if anything can be done on the iPython side.

jbrockmendel
jbrockmendel approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think it's likely this is the/a source of the warnings?

@mroeschke
Copy link
Member Author

Do you think it's likely this is the/a source of the warnings?

I want to say so. It aligns with an unclosed BufferedRandom since it was opened in r+ mode.

Thanks for also raising an issue in iPython ipython/ipython#12495

@mroeschke mroeschke merged commit f5107e4 into pandas-dev:master Dec 1, 2021
@mroeschke mroeschke deleted the tst/ipython_file_leak branch December 1, 2021 18:24
@mroeschke mroeschke added this to the 1.4 milestone Dec 1, 2021
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Dec 1, 2021
@mroeschke mroeschke mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jbrockmendel