ENH: Implement Index.__invert__ #45006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 22, 2021
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -1401,7 +1401,7 @@ class Timedelta(_Timedelta): | |||
| # Arithmetic Methods | |||
| # TODO: Can some of these be defined in the cython class? | |||
|
|
|||
| __inv__ = _op_unary_method(lambda x: -x, '__inv__') | |||
| __inverse__ = _op_unary_method(lambda x: -x, '__inverse__') | |||
There was a problem hiding this comment.
shouldn't this be __invert__?
There was a problem hiding this comment.
huh looks like when i make this __invert__ we get nutty results instead of raising. better to remove it entirely and keep the test that we raise
There was a problem hiding this comment.
updated + greenish (windows timeout)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be considered a bugfix, as we have
__inv__, which i think is a py2 leftover