TST: tests for setitem-like casting issues #45154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Jan 3, 2022
jreback
added
Dtype Conversions
jreback
approved these changes
Jan 3, 2022
| super().test_mask_key(obj, key, expected, val, indexer_sli) | ||
|
|
||
|
|
||
| def test_20643(): |
There was a problem hiding this comment.
can you rename to something more informative
| tm.assert_frame_equal(df, expected_df) | ||
|
|
||
|
|
||
| def test_20643_comment(): |
| tm.assert_series_equal(ser, expected) | ||
|
|
||
|
|
||
| def test_15413(): |
| tm.assert_frame_equal(df, expected) | ||
|
|
||
|
|
||
| def test_37692(indexer_al): |
| tm.assert_series_equal(ser, expected) | ||
|
|
||
|
|
||
| def test_26395(indexer_al): |
| tm.assert_frame_equal(df, expected) | ||
|
|
||
|
|
||
| def test_32878_int_itemsize(): |
| indexer_sli(ser)[0] = np.int64(1) | ||
|
|
||
|
|
||
| def test_6942(indexer_al): |
|
|
||
|
|
||
| @pytest.mark.xfail(reason="unwanted upcast") | ||
| def test_15231(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure a bunch of tests currently in tests.indexing.test_coercion can be ported to use the SetitemCastingEquivalents pattern, but there are some xfails ATM.
Closes a bunch of issues, implements xfailed tests for several more.
Most of the tests this adds will need to be cleaned up/parametrized. ATM im just trying to whittle down the open setitem-casting related issues