BUG: DataFrame[dt64].quantile(axis=1) when empty returning f8 #45294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 10, 2022
jbrockmendel
commented
- closes BUG: Empty DataFrame(..., dtype='datetime64[ns]').quantile(..., axis=1) returns float64 dtype #41544
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Bug
Dtype Conversions
jreback
requested changes
Jan 10, 2022
| ) | ||
| return res.iloc[0] | ||
| res = res_df.iloc[0] | ||
| if axis == 1 and len(self) == 0: |
Contributor
There was a problem hiding this comment.
can we do this in quantile itself?
Member
Author
There was a problem hiding this comment.
no, these cases are only reached when we dont have any blocks to operate on.
Contributor
There was a problem hiding this comment.
hmm really ought to push this down to eliminate this type of logic in the frame itself, ok for now.
mroeschke
approved these changes
Jan 10, 2022
jreback
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.