Skip to content

CI/DOC: replace master -> main branch #45336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

CI/DOC: replace master -> main branch #45336

merged 1 commit into from
Jan 13, 2022

Conversation

jorisvandenbossche
Copy link
Member

Follow-up on #39577

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 12, 2022
Closed
@mroeschke
Copy link
Member

This has failed a few times it appears. Not sure why this PR would influence this failure:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=72190&view=logs&j=c4a134e2-1a49-5486-5bb3-f47b2d22370f&t=a5a6d308-4ac5-5e83-907a-cda493e43b7d&l=49

@mroeschke mroeschke mentioned this pull request Jan 12, 2022
Merged
@jreback
Copy link
Contributor

jreback commented Jan 12, 2022

do we need to backport this? (yes?)

@mroeschke
Copy link
Member

do we need to backport this? (yes?)

I would think so.

@jreback jreback added this to the 1.4 milestone Jan 13, 2022
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Jan 13, 2022
@jreback jreback merged commit 50ac498 into pandas-dev:main Jan 13, 2022
@jreback
Copy link
Contributor

jreback commented Jan 13, 2022

thanks @jorisvandenbossche

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 13, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 13, 2022
@jorisvandenbossche @meeseeksmachine
Backport PR pandas-dev#45336: CI/DOC: replace master -> main branch
efece86
@jreback
Copy link
Contributor

jreback commented Jan 13, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 13, 2022

Something went wrong ... Please have a look at my logs.

@jreback jreback mentioned this pull request Jan 13, 2022
Closed
@areveny areveny mentioned this pull request Jan 13, 2022
Merged
jreback pushed a commit that referenced this pull request Jan 13, 2022
@meeseeksmachine @jorisvandenbossche
Backport PR #45336: CI/DOC: replace master -> main branch (#45338)
92dc85a 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche deleted the master-main-rename branch January 13, 2022 14:16
@jorisvandenbossche
Copy link
Member Author

The backport is actually already done at #45338 by meeseeksdev (not fully sure why he mentioned here that "something went wrong")

@simonjayhawkins
Copy link
Member

because @jreback triggered manually. The bot sometimes does not pick it up (although not noticed this lately)

@jreback
Copy link
Contributor

jreback commented Jan 13, 2022

yeah i always trigger (though i realiE i don't really need to)

@simonjayhawkins
Copy link
Member

yeah i always trigger (though i realiE i don't really need to)

yeah probably safer to make sure nothing gets missed. If the PR has a release note then I check release notes are in sync so these won't get missed. If if fixes ci then again won't get missed as the ci would be failing on the backport branch. If it's a doc fix or some other cleanup then could potentially be missed if the bot does not pick it up and it is not triggered manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jorisvandenbossche @mroeschke @jreback @simonjayhawkins