Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: CategoricalIndex.union with nans #45362

Merged
merged 4 commits into from
Jan 16, 2022
Merged

BUG: CategoricalIndex.union with nans #45362

merged 4 commits into from
Jan 16, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 14, 2022 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

After this and #45359, cast_to_common_type can be refactored to reuse the helper this implements.

@mroeschke mroeschke added this to the 1.5 milestone Jan 15, 2022
@mroeschke mroeschke added Categorical Categorical Data Type setops union, intersection, difference, symmetric_difference labels Jan 15, 2022
@jreback jreback merged commit d2ef7e9 into pandas-dev:main Jan 16, 2022
@jbrockmendel jbrockmendel deleted the bug-cat-setops branch January 16, 2022 17:44
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type setops union, intersection, difference, symmetric_difference
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @jreback