ENH: Add dtypes/converters arguments for pandas.read_xml #45411
Conversation
ParfaitG
commented
Jan 17, 2022
ParfaitG
commented
- closes ENH: Possible to add dtype/converters as arguments for pandas.read_xml() ? #43567
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
IO XML
pandas/io/xml.py
Outdated
| names: Sequence[str] | None, | ||
| dtype: DtypeArg | None, | ||
| converters: dict[str, Callable] | None, | ||
| parse_dates: bool |
There was a problem hiding this comment.
hmm I think we have a typing alias for this? e.g. is this what we are doing in csv parsers?
There was a problem hiding this comment.
I did look in pandas._typing. For read_csv, there is no typing for converters and parse_dates:
def read_csv(
filepath_or_buffer: FilePath | ReadCsvBuffer[bytes] | ReadCsvBuffer[str],
...
# General Parsing Configuration
dtype: DtypeArg | None = None,
...
converters=None,
...
# Datetime Handling
parse_dates=None,
...
):There was a problem hiding this comment.
Same with read_excel. Let me know how to handle typing for read_xml. Maybe raise a TYP issue for future PR?
def read_excel(
io,
...
dtype: DtypeArg | None = None,
...
converters=None,
...
parse_dates=False,
...
)There was a problem hiding this comment.
can you add your alias in _typing and use it (can followup later to use it elsewhere)
doc/source/whatsnew/v1.5.0.rst
Outdated
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Similar to other IO methods, :func:`pandas.read_xml` now supports assigning specific dtypes to columns, | ||
| apply converter methods, and parse dates. |
There was a problem hiding this comment.
can you add the issue reference here (this PR number if no issue)
doc/source/whatsnew/v1.5.0.rst
Outdated
| See :ref:`install.dependencies` and :ref:`install.optional_dependencies` for more. | ||
|
|
||
|
|
||
| .. _whatsnew_140.read_xml_dtypes: |
pandas/io/xml.py
Outdated
| names: Sequence[str] | None, | ||
| dtype: DtypeArg | None, | ||
| converters: dict[str, Callable] | None, | ||
| parse_dates: bool |
There was a problem hiding this comment.
can you add your alias in _typing and use it (can followup later to use it elsewhere)
|
thanks @ParfaitG failures unrelated |
2 participants
