Construction of series with na and datetime dtype #46068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2022 19:01
added 2 commits
February 19, 2022 19:05
weikhor
changed the title
weikhor
changed the title
pandas/core/indexes/base.py
Outdated
| elif ( | ||
| is_float_dtype(self.dtype) | ||
| and needs_i8_conversion(dtype) | ||
| and not np.isnan(values).any() |
There was a problem hiding this comment.
can you add a comment about why this check is needed
There was a problem hiding this comment.
also use self.hasnans as it may be cached
There was a problem hiding this comment.
can you add a comment about why this check is needed
Hi, I just notice this. it is my mistake to add this.
added 3 commits
February 24, 2022 22:00
…ction_of_series_with_NAs_and__datetime_dtype
jreback
added
Constructors
added 2 commits
March 5, 2022 16:47
jreback
requested changes
Mar 6, 2022
jbrockmendel
reviewed
Mar 6, 2022
added 7 commits
March 8, 2022 20:08
…ction_of_series_with_NAs_and__datetime_dtype
jbrockmendel
reviewed
Mar 9, 2022
| @@ -774,6 +775,9 @@ def _try_cast( | |||
| return maybe_cast_to_datetime(arr, dtype) | |||
| # TODO: copy? | |||
|
|
|||
| if isinstance(dtype, IntervalDtype) and isna(arr).all(): | |||
| return np.asarray(arr).astype(IntervalDtype, copy=False) | |||
There was a problem hiding this comment.
this will always raise won't it?
|
I close this since I stuck this for long time. I get simpler task. Thank for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.