CLN: Remove Categorical.itemsize #46137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
approved these changes
Feb 26, 2022
|
Looks good after the merge conflict is resolved |
topper-123
force-pushed
the
categotical_itemsize
branch
from
f9bd4e6 to
fa2ddf0
Compare
|
Rebased. |
mroeschke
approved these changes
Feb 27, 2022
|
Thanks @topper-123 |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* CLN: Remove Categorical.itemsize * fix CI error Co-authored-by: Terji Petersen <terjipetersen@Terjis-Air.fritz.box>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method doesn't even work in main, it is useless and removal keeps the same error code as before, so I think it's OK to just remove and not do a deprecation cycle here: