REF: implement _reconstruct_ea_result, _ea_to_cython_values #46172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Feb 27, 2022
| @@ -1350,6 +1350,10 @@ cdef group_min_max(iu_64_floating_t[:, ::1] out, | |||
| else: | |||
| if uses_mask: | |||
| result_mask[i, j] = True | |||
| # set out[i, j] to 0 to be deterministic, as | |||
There was a problem hiding this comment.
shouldn't you just np.zeros instead of empyt to start?
There was a problem hiding this comment.
empty is cheaper in the non-masked case
|
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=74625&view=results looks like 32 bit failing |
fixed |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea being to eventually refactor those into EA/EADtype methods, xref #43682