Revert "REF: isinstance(x, int) -> is_integer(x)" #46500
Closed
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 541bbf9.
This was referenced Mar 25, 2022
|
closing in favor of #46501 #46501 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46119
It looks like this can be auto reverted. (won't know till ci has run)
@attack68 if we revert this, we could redo and add a regression test for #46384 to address #46119 (comment), add a release note for the bugfix and maybe backport to 1.4.x. wdyt?
I think should probably reopen #46384 and add a test to close that issue off anyway.