Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: add validation checks on levels keyword from pd.concat #46654

Merged
merged 11 commits into from
Apr 7, 2022
Merged

TST: add validation checks on levels keyword from pd.concat #46654

merged 11 commits into from
Apr 7, 2022

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Apr 6, 2022 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Apr 6, 2022 •
edited
Loading

Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-06 20:35:42 UTC

mzeitlin11
mzeitlin11 reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GYHHAHA for the PR! Some small comments

doc/source/whatsnew/v1.5.0.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.5.0.rst Outdated Show resolved Hide resolved
pandas/core/reshape/concat.py Outdated Show resolved Hide resolved
pandas/tests/reshape/concat/test_index.py Outdated Show resolved Hide resolved
@mzeitlin11 mzeitlin11 added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Error Reporting Incorrect or improved errors from pandas labels Apr 6, 2022
GYHHAHA and others added 6 commits April 6, 2022 15:18
@GYHHAHA @mzeitlin11
Update pandas/core/reshape/concat.py
7b516c2 
Co-authored-by: Matthew Zeitlin <37011898+mzeitlin11@users.noreply.github.com>
@GYHHAHA @mzeitlin11
Update doc/source/whatsnew/v1.5.0.rst
9b57d64 
Co-authored-by: Matthew Zeitlin <37011898+mzeitlin11@users.noreply.github.com>
@GYHHAHA @mzeitlin11
Update doc/source/whatsnew/v1.5.0.rst
598fa4b 
Co-authored-by: Matthew Zeitlin <37011898+mzeitlin11@users.noreply.github.com>
@GYHHAHA
Update test_index.py
08508e1
@GYHHAHA
Update test_index.py
067eb67
@GYHHAHA
Update test_index.py
2ec812a
@jreback jreback added this to the 1.5 milestone Apr 7, 2022
@jreback jreback merged commit 361021b into pandas-dev:main Apr 7, 2022
@jreback
Copy link
Contributor

jreback commented Apr 7, 2022

thanks @GYHHAHA very nice!

@GYHHAHA GYHHAHA deleted the patch-1 branch April 7, 2022 00:20
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@GYHHAHA @yehoshuadimarsky
TST: add validation checks on levels keyword from pd.concat (pandas-d…
1349f4b 
…ev#46654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeitlin11 mzeitlin11 mzeitlin11 left review comments

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

TST: add validation checks on levels keyword from pd.concat
4 participants
@GYHHAHA @pep8speaks @jreback @mzeitlin11