Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: add same value count for skew & kurt #46717

Merged
merged 15 commits into from
May 13, 2022

Conversation

auderson
Copy link
Contributor

@auderson auderson commented Apr 9, 2022

REF:

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@auderson auderson changed the title add same value count for skew & kurt EHN: add same value count for skew & kurt Apr 9, 2022
@jreback jreback added the Window rolling, ewma, expanding label Apr 10, 2022
@auderson auderson force-pushed the same_val_counts_for_roll_skew_kurt branch from 6336d8b to 1e63bf5 Compare April 19, 2022 07:11
@jreback
Copy link
Contributor

jreback commented May 8, 2022

@auderson can you merge master here

@jreback jreback added this to the 1.5 milestone May 8, 2022
@auderson
Copy link
Contributor Author

auderson commented May 9, 2022

merged

@auderson
Copy link
Contributor Author

auderson commented May 9, 2022

There appears to be a bug in the main branch.

Update

@jreback All passed finally!

@mroeschke mroeschke merged commit 6f33c46 into pandas-dev:main May 13, 2022
@mroeschke
Copy link
Member

Thanks again @auderson! (Failure unrelated)

@auderson
Copy link
Contributor Author

Thanks again @auderson! (Failure unrelated)

My pleasure

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* add same value count for skew & kurt

* add same value count for skew & kurt

* update doc

* merged

* restore old comments

Co-authored-by: auderson <liao.renjie@techfin.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants