Skip to content

added tests for the test_groupby_dropna.py #46829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added tests for the test_groupby_dropna.py #46829

wants to merge 1 commit into from

Conversation

hhheidi
Copy link

@hhheidi hhheidi commented Apr 22, 2022

@pep8speaks
Copy link

Hello @hhheidi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 352:1: E302 expected 2 blank lines, found 1
Line 363:38: E231 missing whitespace after ','
Line 380:45: W292 no newline at end of file

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run pre-commit locally? This gets rid of the Pep8 stuff.

One of your new tests is failing

Edit: Is the behavior already fixed on master?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label May 23, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to be stale and is failing a lot of the CI checks. If interested in continuing, please fix the formatting and tests failures locally and we can reopen.

@mroeschke mroeschke closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: dropna=False not respected for groupby aggs on result of concatenated dataframes
5 participants