Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: groupby.transform/agg with engine='numba' and a MultiIndex #47057

Merged
merged 3 commits into from
May 19, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Groupby numba numba-accelerated operations labels May 18, 2022
@mroeschke mroeschke added this to the 1.4.3 milestone May 18, 2022
"More than 1 grouping labels are not supported with engine='numba'"
)
# GH 46867
index_data = data.index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i find it weird we support a MI at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, but according to the issue this was (unintentionally) supported is 1.2 apparently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's consider deprecating this though

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green

@mroeschke mroeschke merged commit c4027ad into pandas-dev:main May 19, 2022
@mroeschke mroeschke deleted the bug/gb_numba_multi branch May 19, 2022 16:49
@lumberbot-app

This comment was marked as resolved.

mroeschke added a commit to mroeschke/pandas that referenced this pull request May 19, 2022
…as-dev#47057)

Co-authored-by: Jeff Reback <jeff@reback.net>
(cherry picked from commit c4027ad)
jreback pushed a commit that referenced this pull request May 19, 2022
…ngine='numba' and a MultiIndex) (#47062)

BUG: groupby.transform/agg with engine='numba' and a MultiIndex (#47057)

Co-authored-by: Jeff Reback <jeff@reback.net>
(cherry picked from commit c4027ad)
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby numba numba-accelerated operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby.transform with execution engine numba does not work in multiindex case since 1.3
3 participants