REGR: Regression in to_csv for ea dtype categorical #47347
Conversation
phofl
added
Regression
| ) | ||
| df["a"] = df["a"].astype("category") # astype("object") does not raise an error | ||
| result = df.to_csv() | ||
| expected_rows = [",a", '0,"[2020-01-01, 2020-01-02]"'] |
There was a problem hiding this comment.
has the default closed argument changed on main?
on 1.3.5 and 1.4.2, the expected would be [",a", '0,"(2020-01-01, 2020-01-02]"'] so this test would fail on backport?
print(pd.__version__)
i = pd.Interval(pd.Timestamp("2020-01-01"), pd.Timestamp("2020-01-02"))
print(repr(i))
print(i)1.4.2
Interval('2020-01-01', '2020-01-02', closed='right')
(2020-01-01, 2020-01-02]
1.5.0.dev0+958.gf7be58a477
Interval('2020-01-01', '2020-01-02', inclusive='both')
[2020-01-01, 2020-01-02]
There was a problem hiding this comment.
Looks like it. Inclusive was added which defaults to both, when close is not given. I could not find this in the release notes, so we should either add it or change back to right. Probably would have to deprecate first.
For this pr, I will add closed as a keyword and catch the deprecation warning for main, then we can adjust the test as a follow up
There was a problem hiding this comment.
For this pr, I will add closed as a keyword and catch the deprecation warning for main, then we can adjust the test as a follow up
sgtm
| df = DataFrame( | ||
| {"a": [pd.Interval(Timestamp("2020-01-01"), Timestamp("2020-01-02"))]} | ||
| ) | ||
| df["a"] = df["a"].astype("category") # astype("object") does not raise an error |
There was a problem hiding this comment.
probably can remove this comment that was in the issue OP
There was a problem hiding this comment.
Thx, should have paid more attention…
|
|
||
| def test_to_csv_categorical_and_interval(self): | ||
| # GH#46297 | ||
| with tm.assert_produces_warning(FutureWarning, check_stacklevel=False): |
There was a problem hiding this comment.
if we assert_produces_warning we will need to remove this on the backport. (which is fine imo)
There was a problem hiding this comment.
Ah Right, this would raise without right?
then let’s change to inclusive immediately and change on the backport to right, this makes more sense imo
� Conflicts: � doc/source/whatsnew/v1.4.3.rst
pandas/core/frame.py
Outdated
| res = cache.get(item) | ||
| # res = None |
There was a problem hiding this comment.
these are not needed?
There was a problem hiding this comment.
Thanks for spotting, no definitely not. They got mixed in somehow. Removed
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.