Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: TDA.total_seconds support non-nano #47421

Merged
merged 4 commits into from
Jun 27, 2022
Merged

ENH: TDA.total_seconds support non-nano #47421

merged 4 commits into from
Jun 27, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

Looks like there's a doctest that's failing.

@jbrockmendel
Copy link
Member Author

Looks like there's a doctest that's failing.

neat, looks like this improves floating point error in the relevant case

@mroeschke
Copy link
Member 

pandas/io/excel/_base.py:793: error: List item 0 has incompatible type "Union[int, Sequence[int]]"; expected "int"  [list-item]
pandas/io/excel/_base.py:797: error: Argument 1 to "len" has incompatible type "Union[int, Sequence[int], None]"; expected "Sized"  [arg-type]
pandas/io/excel/_base.py:798: error: Argument 1 to "len" has incompatible type "Union[int, Sequence[int], None]"; expected "Sized"  [arg-type]
Found 3 errors in 1 file (checked 1391 source files)

@mroeschke mroeschke added Timedelta Timedelta data type Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Jun 27, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 27, 2022
@mroeschke mroeschke merged commit 90c7817 into pandas-dev:main Jun 27, 2022
@jbrockmendel jbrockmendel deleted the nano-arith branch June 27, 2022 23:00
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
ENH: TDA.total_seconds support non-nano (pandas-dev#47421)
69f5587 
* ENH: TDA.total_seconds support non-nano

* fix doctest

* mypy fixup
@MarcoGorelli MarcoGorelli mentioned this pull request Sep 20, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution Timedelta Timedelta data type
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke