Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: DTI/DTA.astype support non-nano #47579

Merged
merged 5 commits into from
Jul 5, 2022
Merged

ENH: DTI/DTA.astype support non-nano #47579

merged 5 commits into from
Jul 5, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel added the Non-Nano datetime64/timedelta64 with non-nanosecond resolution label Jul 2, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 5, 2022
mroeschke
mroeschke reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a merge conflict

@mroeschke mroeschke merged commit 67e8c4c into pandas-dev:main Jul 5, 2022
@jbrockmendel jbrockmendel deleted the nano-astype branch July 5, 2022 20:04
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
ENH: DTI/DTA.astype support non-nano (pandas-dev#47579)
77a884a 
* ENH: DTI/DTA.astype support non-nano

* whatsnew

* GH ref

* pyright fixup
@pfiddy pfiddy mentioned this pull request Jan 27, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke