Skip to content

Fix Period not using freq when using same base-freq. #47613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix Period not using freq when using same base-freq. #47613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a827e5
Fix Period not using freq when using same base-freq.
Jul 6, 2022
7929196
Fixup.
Jul 6, 2022
f04f246
Revert change.
Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pandas/_libs/tslibs/period.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2552,12 +2552,11 @@ class Period(_Period):
hour, minute, second, freq)

elif is_period_object(value):
other = value
if freq is None or freq._period_dtype_code == other.freq._period_dtype_code:
ordinal = other.ordinal
freq = other.freq
if freq is None or freq == value.freq:
ordinal = value.ordinal
freq = value.freq
else:
converted = other.asfreq(freq)
converted = value.asfreq(freq)
ordinal = converted.ordinal

elif checknull_with_nat(value) or (isinstance(value, str) and
Expand Down