BUG: df.fillna ignores axis when df is single block #47714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 14, 2022
| return result if not inplace else None | ||
|
|
||
| elif not is_list_like(value): | ||
| if not self._mgr.is_single_block and axis == 1: |
Member
There was a problem hiding this comment.
@jbrockmendel should this be fixed in the block manager fillna?
Contributor
Author
There was a problem hiding this comment.
This is also my question. Originally, I thought delete single block check would fail some tests but it was not. Thus get confused why we need this.
Member
There was a problem hiding this comment.
should this be fixed in the block manager fillna?
i dont think so, the BlockManager method doesn't have an axis keyword
mroeschke
added
the
Missing-data
mroeschke
approved these changes
Jul 14, 2022
Member
|
Thanks @GYHHAHA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.