Skip to content

TST: Add additional test for future warning when call Series.str.cat(Series.str) #47755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2022
Merged

TST: Add additional test for future warning when call Series.str.cat(Series.str) #47755

merged 5 commits into from
Jul 19, 2022

Conversation

xr-chen
Copy link
Contributor

@xr-chen xr-chen commented Jul 16, 2022 •
edited by mroeschke
Loading

mroeschke
mroeschke requested changes Jul 18, 2022
View reviewed changes
@mroeschke mroeschke added the Strings String extension data type and string data label Jul 18, 2022
@xr-chen xr-chen changed the title BUG: Fix Series.str.cat(Series.str) only concatenate the longest string TST: Add additional test for future warning when call Series.str.cat(Series.str) Jul 18, 2022
mroeschke
mroeschke reviewed Jul 18, 2022
View reviewed changes
mroeschke
mroeschke reviewed Jul 18, 2022
View reviewed changes
@xr-chen @mroeschke
Update pandas/tests/strings/test_cat.py
775bc5a 
Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
@pep8speaks
Copy link

pep8speaks commented Jul 19, 2022 •
edited
Loading

Hello @xr-chen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-19 00:53:48 UTC

@mroeschke mroeschke added this to the 1.5 milestone Jul 19, 2022
@mroeschke mroeschke merged commit 3a39d25 into pandas-dev:main Jul 19, 2022
@mroeschke
Copy link
Member

Thanks @xr-chen

@xr-chen xr-chen deleted the catstr branch July 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Strings String extension data type and string data
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

series.str.cat(series.str) is concatenating only the largest string
3 participants
@xr-chen @pep8speaks @mroeschke