Skip to content

add ignore for new mypy error 'type-var' #47766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2022
Merged

add ignore for new mypy error 'type-var' #47766

merged 3 commits into from
Jul 17, 2022

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jul 17, 2022 •
edited
Loading

A new error introduced to mypy is detected in pandas' repository. This PR adds comment to ignore that error.

pandas (https://github.com/pandas-dev/pandas)

  • pandas/core/resample.py:208: error: A function returning TypeVar should receive at least one argument containing the same Typevar [type-var]
  • pandas/core/resample.py:208: note: Error code "type-var" not covered by "type: ignore" comment

Reference:
python/mypy#13166

twoertwein
twoertwein reviewed Jul 17, 2022
View reviewed changes
@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Jul 17, 2022
@twoertwein twoertwein merged commit 08d38a3 into pandas-dev:main Jul 17, 2022
@twoertwein
Copy link
Member

Thank you @anilbey!

@simonjayhawkins simonjayhawkins added this to the 1.5 milestone Jul 18, 2022
@anilbey
Copy link
Contributor Author

anilbey commented Jul 18, 2022

Sure @twoertwein, happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@anilbey @twoertwein @simonjayhawkins