-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: copy keyword to set_axis #47932
Conversation
@Dr-Irv im not clear on what mypy is asking for. help? |
I think the issue is as follows. In inplace: bool_t | lib.NoDefault = ..., But in inplace: bool = ... You have to make sure the signatures are the same in the superclass and subclass for each overload, and that the declared method (without |
green, booyah |
Thanks @jbrockmendel |
* ENH: copy keyword to set_axis * GH ref * fix test * fix test * troubleshoot mypy * mypy fixup * test inplace=True/copy=False case * mypy fixup
This also opens the option of deprecating
inplace
here.doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.