Revert Interval/IntervalIndex/interval_range.inclusive deprecation #48116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d6e0b2.
This reverts commit 102b3ca.
This reverts commit 5506476.
…das-dev#47637)" This reverts commit f6658ef.
…das-dev#46522)" This reverts commit 7e23a37.
…ange (pandas-dev#46355)" This reverts commit 073b353.
Closed
phofl
reviewed
Aug 17, 2022
phofl
reviewed
Aug 17, 2022
pandas/_libs/interval.pyx
Outdated
| @@ -101,7 +96,7 @@ cdef class IntervalMixin: | |||
| Returns | |||
| ------- | |||
| bool | |||
| True if the Interval is not closed on the left-side. | |||
| True if the Interval is closed on the left-side. | |||
There was a problem hiding this comment.
This is technically correct with reverting, but the sentence is wrong. I fixed it in a cleanup pr. Should we avoid reverting this specific change or do a follow up?
There was a problem hiding this comment.
Feel free to push directly to this PR with those cleanups. Looks like c9d4d3d should successfully revert those PRs in the OP, so we can include the cleanups here too.
There was a problem hiding this comment.
Done. I'll open a follow up about cleaning up the typing again. Made this consistent but probably not possible to avoid reverting too
There was a problem hiding this comment.
Okay sounds good to follow up with the typing then.
phofl
reviewed
Aug 17, 2022
| @@ -115,7 +110,7 @@ cdef class IntervalMixin: | |||
| Returns | |||
| ------- | |||
| bool | |||
| True if the Interval is not closed on the right-side. | |||
|
Looks good, but impossible to see everything... |
phofl
approved these changes
Aug 18, 2022
3 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…andas-dev#48116) * Revert "Cln tests interval wrt inclusive (pandas-dev#47775)" This reverts commit 2d6e0b2. * Revert "CLN: Rename private variables to inclusive (pandas-dev#47655)" This reverts commit 102b3ca. * Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)" This reverts commit 5506476. * Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)" This reverts commit bd4ff39. * Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)" This reverts commit f6658ef. * Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)" This reverts commit d9dd128. * Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)" This reverts commit 7e23a37. * Revert "ENH: consistency of input args for boundaries - pd.interval_range (pandas-dev#46355)" This reverts commit 073b353. * Fix ArrowIntervalType manually * Remove unused import * Fix doctest and leftover usage * Fix remaining tests * Fix wording in doctoring Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #47365 (comment)
Reverts these PRs
#47775
#47655
#47646
#47636
#47637
#47367
#46522
#46355
@phofl would appreciate a look since you did a lot of the cleanup post deprecation (and there were tons of merge conflicts reverting along the way)