-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: droplevel copy keyword #48117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: droplevel copy keyword #48117
Conversation
One merge conflict otherwise LGTM |
i think CI fail is unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel I see you did already another PR to add copy
to set_axis
as well. In general (and certainly if you are planning a concerted effort to add this to several methods), it would be helpful if you would create an issue for this that can be referenced, and to give some context for the proposed change.
Personally, I am not sure we should actually add those keywords right now (or we should at least have some discussion about it). I know we already have some places that have such a keyword (and in general I would like to see this used more as well). But with #46958 we are also planning to change the behaviour of that keyword.
So we would be adding a new feature that might actually change behaviour in one the next releases. And that change of behaviour is quite subtle (it's not something that we can easily deprecate about for those specific cases). I would really like to avoid that more people start to rely on the mutability of dataframes returned in such a copy=False
case.
opened #48141 |
Thanks for opening the issue! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.