Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: standardized footer GH48012 #48202

Closed
wants to merge 6 commits into from
Closed

Conversation

FrnRmn
Copy link
Contributor

@FrnRmn FrnRmn commented Aug 22, 2022

@mroeschke mroeschke added the Web pandas website label Aug 23, 2022
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrnRmn for working on this, and sorry for the delay with the review.

I'd also make the changes to the docs footer here. I've seen you say on the ticket that you could only partially make them, but probably good enough for now. Thanks!

@@ -91,7 +91,7 @@
</li>
</ul>
<p>
pandas is a fiscally sponsored project of <a href="https://numfocus.org">NumFOCUS.</a>
© 2022 pandas via <a href="https://numfocus.org">NumFOCUS.</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use NumFOCUS, Inc. instead please, that's the legal name.

For the year, can you make it be generated dynamically, so we don't need to update it every year? I'm not sure if jinja allows direct access to the datetime module, or what the best option could be. Feel free to add the year to the context if you think that's the best, or also use javascript

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I'll try soon!

@FrnRmn
Copy link
Contributor Author

FrnRmn commented Sep 10, 2022

Ups, I ended up updating the PR before I intended. I wanted to merge the commits into a single commit with a better name :/ Sorry for that

@datapythonista
Copy link
Member

Ups, I ended up updating the PR before I intended. I wanted to merge the commits into a single commit with a better name :/ Sorry for that

Don't worry about it, we squash all the commits into one when we merge PRs, so it doesn't add much value to squash them before. And in some cases it's useful to have separate commits, so we don't need to review everything again, and can check just what changed.

Checking your changes, I'm wondering if it'd make sense to have the footer content for the website in the configuration yaml. I think we the whole config to the context, so not much change would be needed, except for the year. For it, a simple content preprocessor that replaces a string like {year} by the current year could be used. I think this could be a bit better than the javascript. But happy to use the javascript if you have a strong preference for it.

For Sphinx, is Sphinx adding the word Copyright automatically? That's annoying, quite a poor design decision in my opinion. If you want to have a quick look and see if there is an easy way to overwrite that, it would be great. But I wouldn't spend too much time on it, Sphinx code is a huge mess.

@datapythonista
Copy link
Member

I opened #48543 to update the footer for the docs, as we want to have it merged before the release on Monday. I'll let you continue here with the update for the website, which is independent from the release.

@FrnRmn
Copy link
Contributor Author

FrnRmn commented Sep 14, 2022

@datapythonista hi, sorry just wanted to let you know that I started working today and have a lot to do now. If it is something with a deadline please go ahead. Otherwise, I might take a while (like a couple of weeks) :)

@datapythonista
Copy link
Member

No problem, thanks for letting us know. If I have the time to look at this before you, I'll let you know and close this PR. Thanks for the work on this!

@datapythonista
Copy link
Member

Superseded by #48557

Thanks @FrnRmn for the work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB: Standardize website/docs footer
3 participants