CI: Automatically upload docs on release #48211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the publishing of the docs automatic one creating and pushing a new tag. My understanding is that versioneer should take care of showing the version correctly in the docs.
I'd merge this before the 1.5 release in few hours, and if there is any problem, we do the publishing manually once more, and we fix the action for the next release. But I don't think it should fail.
The pdf is missing, but I think we're happy to remove it (I'll open a separate PR for it).
If I'm not wrong, for patch releases we upload the new docs, but delete the previous docs of that minor (so, for 1.4.4 we would delete 1.4.3 docs), and we create a symlink for the previous release. If that's the case, this would still be useful, but we should add in a follow up the deleting and the symlinks.
CC: @simonjayhawkins @mroeschke @lithomas1 @jorisvandenbossche