Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Skip test_round_sanity tests due to failures #48245

Merged
merged 1 commit into from
Aug 25, 2022
Merged

CI: Skip test_round_sanity tests due to failures #48245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pandas/tests/scalar/timedelta/test_timedelta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
iNaT,
)
from pandas._libs.tslibs.dtypes import NpyDatetimeUnit
from pandas.compat import IS64
from pandas.errors import OutOfBoundsTimedelta

import pandas as pd
Expand Down Expand Up @@ -691,7 +690,7 @@ def test_round_implementation_bounds(self):
with pytest.raises(OverflowError, match=msg):
Timedelta.max.ceil("s")

@pytest.mark.xfail(not IS64, reason="Failing on 32 bit build", strict=False)
@pytest.mark.xfail(reason="Failing on builds", strict=False)
@given(val=st.integers(min_value=iNaT + 1, max_value=lib.i8max))
@pytest.mark.parametrize(
"method", [Timedelta.round, Timedelta.floor, Timedelta.ceil]
Expand Down
3 changes: 1 addition & 2 deletions pandas/tests/scalar/timestamp/test_unary_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
)
from pandas._libs.tslibs.dtypes import NpyDatetimeUnit
from pandas._libs.tslibs.period import INVALID_FREQ_ERR_MSG
from pandas.compat import IS64
import pandas.util._test_decorators as td

import pandas._testing as tm
Expand Down Expand Up @@ -298,7 +297,7 @@ def test_round_implementation_bounds(self):
with pytest.raises(OverflowError, match=msg):
Timestamp.max.ceil("s")

@pytest.mark.xfail(not IS64, reason="Failing on 32 bit build", strict=False)
@pytest.mark.xfail(reason="Failing on builds", strict=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we check raises=OverflowError so this test is still somewhat useful? If not practical, I am still fine with this for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is really practical, ceil works, the other two fail most of the time, but not sure if round fails every time

@given(val=st.integers(iNaT + 1, lib.i8max))
@pytest.mark.parametrize(
"method", [Timestamp.round, Timestamp.floor, Timestamp.ceil]
Expand Down