Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Require s3fs greater than minumum version in builds #48272

Merged
merged 2 commits into from
Aug 26, 2022
Merged

CI: Require s3fs greater than minumum version in builds #48272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294b12c
CI: Require s3fs greater than minumum version in builds
phofl Aug 26, 2022
8638b16
Pin aiobotocore too
phofl Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/deps/actions-310.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies:
- pytz

# optional dependencies
- aiobotocore<2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this above:

#48272 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just bump s3fs? The regular workflows are supposed be testing the latest dependencies anyways. It was green for me locally, so I'm going to try it in #48291.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have a preference here, but in general we should not restrict the solver more than necessary regarding our direct dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks like a mamba bug, since we're pulling a really old s3fs. It's weird too, since mamba repoquery whoneeds s3fs
gives me No entries matching "s3fs" found

- beautifulsoup4
- blosc
- bottleneck
Expand All @@ -43,7 +44,7 @@ dependencies:
- pyreadstat
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-38-downstream_compat.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ dependencies:
- pytables
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
3 changes: 2 additions & 1 deletion ci/deps/actions-38.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies:
- pytz

# optional dependencies
- aiobotocore<2.0.0
- beautifulsoup4
- blosc
- bottleneck
Expand All @@ -43,7 +44,7 @@ dependencies:
- pytables
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
3 changes: 2 additions & 1 deletion ci/deps/actions-39.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies:
- pytz

# optional dependencies
- aiobotocore<2.0.0
- beautifulsoup4
- blosc
- bottleneck
Expand All @@ -43,7 +44,7 @@ dependencies:
- pytables
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
3 changes: 2 additions & 1 deletion ci/deps/circle-38-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies:
- pytz

# optional dependencies
- aiobotocore<2.0.0
- beautifulsoup4
- blosc
- bottleneck
Expand All @@ -44,7 +45,7 @@ dependencies:
- pytables
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ dependencies:
- pytables
- python-snappy
- pyxlsb
- s3fs
- s3fs>=2021.05.0
- scipy
- sqlalchemy
- tabulate
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pyreadstat
tables
python-snappy
pyxlsb
s3fs
s3fs>=2021.05.0
scipy
sqlalchemy
tabulate
Expand Down