CLN, STYLE: remove unused variables and imports in Cython files #48290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
| @@ -26,6 +26,10 @@ repos: | |||
| hooks: | |||
| - id: codespell | |||
| types_or: [python, rst, markdown] | |||
| - repo: https://github.com/MarcoGorelli/cython-lint | |||
There was a problem hiding this comment.
just glancing at this, im stoked at the concept!
There was a problem hiding this comment.
does this have/need eyeballs?
There was a problem hiding this comment.
Would certainly help if you're interested, thanks!
mroeschke
approved these changes
Sep 7, 2022
|
Great cleanup @MarcoGorelli! |
|
It would be interesting to know why a lot of these unused variables don't get picked up via build warnings |
|
I think the build warnings just pick up unreachable code |
|
Gcc/llvm should warn for unused variables with the flags we have (-Wunused-variable us part of -Wall). My guess is Cython is generating code that still "uses" these variables and prevents that from happening. Likely hard to fix but in an ideal would that wouldn't happen in the first place |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…as-dev#48290) * remove unused variables and imports * wip * bump to 0.1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Tried putting together a little Cython linter, here's the unused variables/imports it finds. More to come, but this already cleans up quite a few things