BUG/PERF: MultiIndex setops with sort=None #49010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.6.0.rst
file if fixing a bug or adding a new feature.Simplify and improve perf in algos.safe_sort which improves perf in MultiIndex setops when sort=None.
I updated the expected value in
test_union_nan_got_duplicated
which was added in #38977.MultiIndex.union
sorts by default but the expected value in that test was not sorted.For reference, here are the docs for the sort parameter:
pandas/pandas/core/indexes/base.py
Lines 3297 to 3305 in 55dc324