REGR: MultiIndex.join does not work for ea dtypes #49284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
mroeschke
reviewed
Oct 26, 2022
| @@ -4636,8 +4636,9 @@ def join( | |||
| return self._join_non_unique(other, how=how) | |||
| elif not self.is_unique or not other.is_unique: | |||
| if self.is_monotonic_increasing and other.is_monotonic_increasing: | |||
| if self._can_use_libjoin: | |||
| if not is_interval_dtype(self.dtype): | |||
There was a problem hiding this comment.
So _can_use_libjoin shouldn't be updated instead?
There was a problem hiding this comment.
No, in most cases going through object dtype is slower than the alternative. In our case here the alternative can not handle non interval dtype
mroeschke
reviewed
Oct 26, 2022
| # otherwise we will fall through to _join_via_get_indexer | ||
| # go through object dtype for ea till engine is supported properly |
There was a problem hiding this comment.
Do we have a GH issue related to an engine for EAs?
3 tasks
# Conflicts: # doc/source/whatsnew/v1.5.2.rst
mroeschke
approved these changes
Nov 10, 2022
|
good to merge @mroeschke ? |
|
Thanks @phofl |
|
Oops, something went wrong applying the patch ... Please have a look at my logs. |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Nov 10, 2022
* REGR: MultiIndex.join does not work for ea dtypes * Update base.py (cherry picked from commit f82b1c6)
codamuse
pushed a commit
to codamuse/pandas
that referenced
this pull request
Nov 12, 2022
* REGR: MultiIndex.join does not work for ea dtypes * Update base.py
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* REGR: MultiIndex.join does not work for ea dtypes * Update base.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This can not fall through for regular ea dtypes, rather go through object path